PostHog / posthog

🦔 PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.
https://posthog.com
Other
19.35k stars 1.13k forks source link

fix: message size two large #23304

Closed pauldambra closed 4 days ago

pauldambra commented 5 days ago

follow up to https://github.com/PostHog/posthog/pull/23268

the mocks in the capture tests made the MessageSizeTooLarge solution work in tests, but it doesn't work in practice, sad times

this PR:

metric in place ready at https://grafana.prod-us.posthog.dev/d/session-replay/session-replay?var-role=recordings-blob-ingestion&var-pod=$__all&var-partition=$__all&from=now-1h&to=now&timezone=utc&tab=queries&viewPanel=panel-74

this set of exception handlers is pretty ugly now but i don't want to spend time refactoring this till i've confirmed it has the desired effect in prod

sentry-io[bot] commented 5 days ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/api/capture.py

Function Unhandled Issue
get_event UnicodeDecodeError: 'utf-16-le' codec can't decode bytes in position 21438-21439: illegal UTF-16 surrogate ...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] commented 4 days ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎