PostHog / posthog

đŸĻ” PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.
https://posthog.com
Other
21.2k stars 1.26k forks source link

chore: Enable person batch exports only on supported destinations #23354

Closed tomasfarias closed 3 months ago

tomasfarias commented 3 months ago

Problem

Simply make the PERSONS_BATCH_EXPORTS flag also conditional on destination.

Changes

Check for destination type before exposing model field.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

posthog-bot commented 3 months ago

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot commented 3 months ago

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions[bot] commented 3 months ago

Size Change: 0 B

Total Size: 1.06 MB

ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `frontend/dist/toolbar.js` | 1.06 MB |

compressed-size-action