Experiments HogQL rewrite

[jurajmajerik]

Trends

• [x] Set up a query runner
• [x] Retrieve Experiment
• [x] Prepare Trend query
  • Display type
  • Start/end dates
  • Flag breakdown
• [x] Prepare exposure query
  • Events/actions
  • Start/end dates
  • Flag breakdown
  • Default feature flag exposure filter
• [x] Handle math aggregation path
• [x] Add statistical calculations
• [x] Custom errors
• [x] Filter out test accounts
• [x] Copy over existing tests
• [ ] Port holdout groups

Funnels

• [x] Set up a query runner
• [x] Retrieve Experiment
• [x] Prepare Funnel query
  • Display type
  • Start/end dates
  • Flag breakdown
  • Reset properties
• [x] Add statistical calculations
• [x] Custom errors
• [x] Filter out test accounts
• [x] Copy over existing tests
• [ ] Port holdout groups

Schema migration

• [x] Add a metrics field
• [ ] Validate metrics field
• [ ] Migrate Experiment records

Frontend

• [x] Call /query for primary metric
• [x] Call /query for secondary metrics
• [ ] Set insight (Form)
• [ ] Set insight (MetricSelector)
• [ ] Set insight (ActionFilter)
• [ ] ^^Repeat for the Trends exposure query
• [ ] ^^Repeat for secondary metrics
• [ ] Set query received from the Insight to filters/metrics
• [ ] Ensure backwards compatibility (transform filters to query)
• [ ] Retrieve from cache vs. recalculate

[abigailbramble]

https://posthoghelp.zendesk.com/agent/tickets/19665 and https://posthoghelp.zendesk.com/agent/tickets/19431 both seeing experiment results affected by anonymous events. It looks like experiments are unintentionally filtering out anonymous people: see this thread This will be fixed by the above migration.

[darkopia]

+1 to this. https://posthoghelp.zendesk.com/agent/tickets/20108 In this instance, removing any person property filters lead to matching results.