Experiments HogQL rewrite - Githubissues

PostHog / posthog

🦔 PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.

https://posthog.com

Other

21.59k stars 1.29k forks source link

Experiments HogQL rewrite #24914

Open jurajmajerik opened 1 month ago

jurajmajerik commented 1 month ago

Trends

[x] Set up a query runner
[x] Retrieve Experiment
[x] Prepare Trend query
- Display type
- Start/end dates
- Flag breakdown
[x] Prepare exposure query
- Events/actions
- Start/end dates
- Flag breakdown
- Default feature flag exposure filter
[x] Handle math aggregation path
[x] Add statistical calculations
[x] Custom errors
[x] Filter out test accounts
[x] Copy over existing tests

Funnels

[x] Set up a query runner
[x] Retrieve Experiment
[x] Prepare Funnel query
- Display type
- Start/end dates
- Flag breakdown
- Reset properties
[x] Add statistical calculations
[x] Custom errors
[x] Filter out test accounts
[x] Copy over existing tests

Schema migration

[x] Add a metrics field
[ ] Migrate Experiment records

Frontend

[ ] Call /query - primary metric
[ ] Call /query - secondary metrics
[ ] Ensure backwards compatibility (transform filters to query)
[ ] Retrieve from cache vs. recalculate

Debug info

- [ ] PostHog Cloud, Debug information: [please copy/paste from https://us.posthog.com/settings/project-details#variables]
- [ ] PostHog Hobby self-hosted with `docker compose`, version/commit: [please provide]
- [ ] PostHog self-hosted with Kubernetes (deprecated, see [`Sunsetting Kubernetes support`](https://posthog.com/blog/sunsetting-helm-support-posthog)), version/commit: [please provide]

abigailbramble commented 10 hours ago

https://posthoghelp.zendesk.com/agent/tickets/19665 and https://posthoghelp.zendesk.com/agent/tickets/19431 both seeing experiment results affected by anonymous events. It looks like experiments are unintentionally filtering out anonymous people: see this thread This will be fixed by the above migration.