PostHog / posthog

🦔 PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.
https://posthog.com
Other
20.77k stars 1.24k forks source link

UI issues when accepting an invite #24971

Open corywatilo opened 4 days ago

corywatilo commented 4 days ago

I was watching a user accept an invite and witnessed a couple oddities that would be worth fixing. I didn't try to repro them again, so not sure if they were flukes, but worth checking the next time someone is working in here.

  1. Clicking into the empty password field didn't automatically pop up the suggest password dropdown. I was able to right-click where I found the option to "Suggest password", but it was odd that it didn't open when clicking into the input once like most other websites.
  2. When clicking the yellow submit button to create the account (after entering a password), a red dot (I think it was a dot?) appeared below the input, making it look like there was an issue with password validation (but with no text displayed). But after the form processed, it correctly went to the email verification screen. So, just looks like something is up with the password validation on the UI side.
prankurpandeyy commented 3 days ago

I would like to work on this issue

ctrl-alter-ego commented 1 day ago

Hi @corywatilo, I can replicate the second part (a red exclamation mark appears under password field, even if creating account is successful) but I don't see a suggest password feature. Does PostHog have one built-in and I'm just not seeing it, or might this have been a browser plugin you have, like 1password, for example? Apologies if I'm missing something obvious.

EDIT: To further aid debugging, the red exclamation under password will also appear if omitting a name, (it's not related to this, however, as this has its own red exclamation icon and the one under the password field can be seen briefly before the page submits successfully). It's just a good way to get it to show up indefinitely, if helpful.

abhi12299 commented 1 day ago

@ctrl-alter-ego it seems like a browser plugin. I've not seen any other website show the pop-up natively either.

Also, the form error handling is fixed #24982 - it handles all the fields properly.

ctrl-alter-ego commented 21 hours ago

Aha, excellent. Thanks for the update @abhi12299.