PostgREST / postgrest

REST API for any Postgres database
https://postgrest.org
MIT License
22.65k stars 1k forks source link

Remove Template Haskell from `postgrest --version` #3608

Closed wolfgangwalther closed 1 week ago

wolfgangwalther commented 1 week ago

The first commit fixes some things around the pre-release detection which we missed for our new release workflow. The first commit should be backpatched to v12.

The next commit removes the dependency on Paths_ - reasons given in the commit message.

The last two commits are "either one or the other". I'd like to remove the dependency on template haskell in our own code, reading the git hash. I have a working replacement via CPP macros, but that's jumping some hoops. I haven't tried to make that work for the Windows build, because the shell syntax is different there. In any case, this doesn't change the fact that this will never work for any nix-based builds - because the commit hash is just not part of the files that the build is based on. This will also never happen if we want to avoid full rebuilds on every commit, because the hash changes.

Thus, the other option is to just remove that git hash thing from our version entirely.

Opinions?