search

PostgREST / postgrest

REST API for any Postgres database
https://postgrest.org
MIT License
23.46k stars 1.03k forks source link

remove support for Prefer: params=single-object #3757

Closed joelonsql closed 2 weeks ago

joelonsql commented 3 weeks ago

Using this preference was deprecated in 6c3d7a9, in favor of Functions with an array of JSON objects.

This change removes support for this feature, planned for the next major version.

wolfgangwalther commented 2 weeks ago

I don't think the CHANGELOG was addressed properly. Now we have a Removed section at the top. We didn't have any removed sections before and if so we should have it at the bottom. In any case, the PG removal should be in the same section. As I wrote above, this should just be in the "Changed" section.

Also, @steve-chavez, I think we loosely agreed on some form of conventional commits, i.e. using prefixes. The squashed commit message has none.

steve-chavez commented 2 weeks ago

Ah, my bad, I thought it was addressed. How about this?

All in one push to main?

steve-chavez commented 2 weeks ago

Also, @steve-chavez, I think we loosely agreed on some form of conventional commits, i.e. using prefixes. The squashed commit message has none.

Btw, maybe we can enforce this somehow? https://dev.to/mbarzeev/a-git-hook-for-commit-messages-validation-no-husky-just-js-1hni

I guess squash would have to be disabled too.

wolfgangwalther commented 2 weeks ago

I don't think you need to revert. I'd say it's fine to just do the changelog in a follow up commit.

We'd have to think about the proper commit prefix for something like this. I used feat: for the old PG versions removal, but maybe we should just introduce remove:?

Btw, maybe we can enforce this somehow?

Yeah, I use commitlint in a different project. Works well. We'd have to standardize on the prefixes first, though ;)

wolfgangwalther commented 2 weeks ago

I guess squash would have to be disabled too.

No, I think squash is fine. You can still edit the commit message when squashing.

steve-chavez commented 2 weeks ago

We'd have to think about the proper commit prefix for something like this. I used feat: for the old PG versions removal, but maybe we should just introduce remove:?

remove: LGTM.

Fixed the changelog on https://github.com/PostgREST/postgrest/commit/b821857861301aecdb897c57a3c701e04aa4e837