search

PostgreSQL-For-Wordpress / postgresql-for-wordpress

A maintained fork of https://wordpress.org/plugins/postgresql-for-wordpress/
GNU General Public License v2.0
209 stars 68 forks source link

(Draft) Trying to fix BIGINT issues #116

Open 0xFEEDC0DE64 opened 3 months ago

0xFEEDC0DE64 commented 3 months ago

I think we should not only cover BIGINT and not only in CREATE TABLE statements...

but this is for now what fixes my problem with wp-statistics

mattbucci commented 3 months ago

Most of these regexes are already case insensitive.

I think we can just add an "i" to the end of https://github.com/PostgreSQL-For-Wordpress/postgresql-for-wordpress/blob/716db95999756ad94d53733e8ca7787a29c13642/pg4wp/rewriters/CreateTableSQLRewriter.php#L99

This should make this case insensitive and either bigint variation should match

mattbucci commented 3 months ago

Looks like we have a failing test, but it's the test itself that is incorrect.

1) rewriteTest::test_it_removes_character_sets
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
platform varchar(255),
version varchar(255),
location varchar(10),
- user_id BIGINT(48) NOT NULL,
- page_id BIGINT(48) NOT NULL,
+ user_id BIGINT NOT NULL,
+ page_id BIGINT NOT NULL,