PHP 8 and Wordpress 6+ support

[mattbucci]

I don't expect this to get merged, but I just spent the last week getting this package working on a fresh WP install and I'd like to make it available for anyone who might want it.

This PR includes code from the following PRs:

• https://github.com/kevinoid/postgresql-for-wordpress/pull/19
• https://github.com/kevinoid/postgresql-for-wordpress/pull/16
• https://github.com/kevinoid/postgresql-for-wordpress/pull/30
• https://github.com/kevinoid/postgresql-for-wordpress/pull/29
• https://github.com/kevinoid/postgresql-for-wordpress/pull/28

This PR also includes

• Docblock comments for each method
• A refactor towards a class based polymorphic implementation of SQLRewriters which allows better groking of what's happening with all these regexes
• 3 new methods for handling the following situations I ran into when testing
  • Ensure the columns used in the ORDER BY clause are also present in the SELECT clause.
  • Ensuring Group By is added if it needs to be due to aggregated columns
  • Converting MySQL LIMIT syntax to PostgreSQL LIMIT syntax more reliably
• New Logic for handling the SHOW FULL COLUMNS query

[kevinoid]

Thanks @mattbucci, your PRs are great and this one is particularly ambitious! Would you be interested in taking over as the maintainer of this project?

Unfortunately, I haven't had time to work on it for quite a while (partly because I don't have any sites which use it at the moment) and it has languished as a result. I think there are a lot of users, and potential users, who would benefit from more active maintenance. If you'd be interested, I'd be willing to transfer the project to you. Alternatively, if you'd rather co-maintain the project, I could transfer it to a GitHub organization, or just grant you permission to this repo. What do you think?

[mattbucci]

Thanks for the kind words.

I have some ideas about how to move forward with it including adding a battery of tests and would be willing to maintain / support it.

For now if you granted me permission to this repo I'd be happy to start working on some branches and a release strategy, as this repo is often mentioned in various blogs I think it would be best to start with maintaining it in it's current location and then decide how to proceed from there.

On Sat, Oct 28, 2023 at 2:51 PM Kevin Locke @.***> wrote:

Thanks @mattbucci https://github.com/mattbucci, your PRs are great and this one is particularly ambitious! Would you be interested in taking over as the maintainer of this project?

Unfortunately, I haven't had time to work on it for quite a while (partly because I don't have any sites which use it at the moment) and it has languished as a result. I think there are a lot of users, and potential users, who would benefit from more active maintenance. If you'd be interested, I'd be willing to transfer the project to you. Alternatively, if you'd rather co-maintain the project, I could transfer it to a GitHub organization, or just grant you permission to this repo. What do you think?

— Reply to this email directly, view it on GitHub https://github.com/kevinoid/postgresql-for-wordpress/pull/31#issuecomment-1783928029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZBZM3SVWLGF3ZGMVAXVILYBV47BAVCNFSM6AAAAAA6T7J34GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHEZDQMBSHE . You are receiving this because you were mentioned.Message ID: @.***>

[kevinoid]

Great! I've sent you an invite to collaborate on this project. Once you are in, feel free to merge any of the PRs and start implementing the ideas you have in mind.

as this repo is often mentioned in various blogs I think it would be best to start with maintaining it in it's current location and then decide how to proceed from there.

Makes sense to me. For reference, my understanding is that when a repository is moved, GitHub will redirect from the previous project URL to the new one, so it shouldn't break those links. There are always risks and minor incompatibilities though, so I agree with moving slow. If you'd like to take ownership of the project or move it to an organization at any point in the future, just let me know.

[mattbucci]

@kevinoid I sent you an invite to https://github.com/PostgreSQL-For-Wordpress which is an org where this repo can live moving forward whenever you want to migrate it.

[kevinoid]

Thanks @mattbucci! I love all the work you've been doing on this project; thanks so much! I've transferred it to the new org. Let me know if there's anything else I can do to help.