Monkey patching wpdb means that we can pull in changes in behavior from WordPress core when they are introduced, implementing our own version could cause drift, but eval'ing the string replaced wpdb class like we do in core.php seems like bad practice. What if users want to disable eval for security reasons? They wouldn't be able to use this plugin.
Wouldn't it be more straightforward to just provide a wpdb class of our own?
Monkey patching wpdb means that we can pull in changes in behavior from WordPress core when they are introduced, implementing our own version could cause drift, but eval'ing the string replaced wpdb class like we do in core.php seems like bad practice. What if users want to disable eval for security reasons? They wouldn't be able to use this plugin.
Wouldn't it be more straightforward to just provide a wpdb class of our own?
This is an open discussion