hahnn
commented
8 months ago I'm trying to investigate in the code. (I'm far from being a good PHP developer :-D)
I see this:
// Fix auto_increment by adding a sequence
$pattern = '/int[ ]+NOT NULL auto_increment/i';
preg_match($pattern, $sql, $matches);
if($matches) {
$seq = $table . '_seq';
$sql = str_ireplace('NOT NULL auto_increment', "NOT NULL DEFAULT nextval('$seq'::text)", $sql);
$sql .= "\nCREATE SEQUENCE $seq;";
}
I'm wondering if this will solve the issue about the wp_e_events SQL table for example, because the SQL code sent to PostgreSQL at this time, as seen in my audit logs, is:
CREATE TABLE wp_e_events (
id bigint auto_increment primary key,
event_data text null,
created_at timestamp not null
) ;;As you can see, the line about the id column has an auto_increment directive, but there is no NOT NULL directive inside.
So maybe this line will not match the $pattern PHP line of code because it seems to me this line of code is looking for the NOT NULL directive, which potentially doesn't exist depending of how SQL tables are created.
Finally, what I mean is that in the $pattern PHP line of code, the presence of NOT NULL directive is optionnal. If you can make it optionnal, this should match this kind of cases.
Any way, in PostgreSQL, the simple fact to create a primay key on a column implies the fact the column is NOT NULL automatically. See below on my example, where I create a test table without specifying the NOT NULL directive, but when displaying the description of the table, the NOT NULL is automatically there on the column because of the existence of the primary key:
admcoquelicots=# create table test(id int4 primary key);
CREATE TABLE
admcoquelicots=# \d test
Table « public.test »
Colonne | Type | Collationnement | NULL-able | Par défaut
---------+---------+-----------------+-----------+------------
id | integer | | not null |
Index :
"test_pkey" PRIMARY KEY, btree (id)
admcoquelicots=#
What do you think ?
mattbucci
Closes: https://github.com/PostgreSQL-For-Wordpress/postgresql-for-wordpress/issues/73