Add timescaledb extension

PostgresApp / PostgresApp

The easiest way to get started with PostgreSQL on the Mac

https://postgresapp.com

Other

7.19k stars 371 forks source link

Add timescaledb extension #504

Open mashaalmemon opened 5 years ago

mashaalmemon commented 5 years ago

Would like to request that the TimescaleDb extension be added to the distribution?

Azure will be adding this extension in their managed Postgres environment as of this month as can be seen here. We would love to have the extension available in our local development environments, which today is Postgres.app.

jakob commented 5 years ago

How difficult is building Timescale yourself with Postgres.app? Do the instructions from their docs work with Postgres.app? https://docs.timescale.com/v1.2/getting-started/installation/macos/installation-source

I understand that it would be nice to have out-of-the-box support like with PostGIS, but I really don't know how popular TimescaleDB is. Building Postgres.app is a lot of work already, so I'm not all too eager to add even more things...

mashaalmemon commented 5 years ago

Hi Jacob,

I just went through the process and it isn't very difficult at all. I had to do a bit of digging around in order to figure out how to have the "pg_config" of the particular server version be the one that TimescaleDB would use, but once I figured that out it was pretty smooth sailing.

The instructions for timescale work except:

You need the local "pg_config" from the postgres.app version of Postgres to be the default.
"./bootstrap" will not work if you don't have "openssl" installed, but you can ignore that with a switch like so: "./bootstrap -DUSE_OPENSSL=0"
Other than this the instructions seem to work well and extension was installed from source without a hitch.

Re out of the box support, understand how that can add overhead. Perhaps in lieu of this, it makes sense to add some info into the documentation on how to install extensions?

slashdotdash commented 4 years ago

I've written up a step-by-step guide to installing TimescaleDB with Postgres.app following the "install from source" instructions.

mindreframer commented 3 years ago

Hey @jakob, here is a detailed instruction from timescaledb about how to install it on OSX:

https://docs.timescale.com/latest/getting-started/installation/macos/installation-source It does not look too crazy, maybe we could add this to PostgresApp?

Thanks, grateful user of PostgresApp, :)

jakob commented 3 years ago

Since there seems to be some interest in bundling TimescaleDB, I've looked at their website a bit to see if it would be a good fit.

Two things I saw that are worth mentioning:

They apparently support PostgreSQL 11 and 12 only. So we can't add it to the latest version, only to the older versions that we build.
Apparently it's not fully open source licensed. It seems that some parts are Apache licenced, and some use a "Timescale License". It wasn't immediately obvious to me what this means, so that would require some review. Postgres.app is fully open source, and we're not going to include anything that would restrict what you can do with it. Apparently there is a way to build only Apache 2 licensed parts, but I have no idea if that is useful.

lithammer commented 3 years ago

This blog post might shed some light on their license as of v2.0: https://blog.timescale.com/blog/building-open-source-business-in-cloud-era-v2/

jakob commented 3 years ago

@lithammer Thanks for the link. Unfortunately that blog post doesn't answer my main question, which is whether including only the Apache 2 licensed parts is useful.

tbussmann commented 3 years ago

Useful or not, the demand for the other parts will likely continue. I'd rather take this extension as a good candidate for the planned 'HowTo build my favourite extension' repository then for inclusion by default in PostgresApp. There are many exciting extensions but most are only interesting for a small fraction of users.

The OP mentioned support from cloud providers as a motivation of the request. That is something that may be worth a general investigation. I did not find quickly an overview which extensions are supported by what cloud providers. There will be some that single out individual providers like citus but others may be common among them.