search

PotatoCraft-Studio / QuickShop-Reremake

QuickShop-Reremake is a **FREE** shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop-Reremake provides are ever needed by a player.
GNU General Public License v3.0
71 stars 75 forks source link

[BUG] QuickShops gets stuck downloading game assets every initialization. #142

Closed mibby closed 2 years ago

mibby commented 2 years ago

QuickShop-Remake-SNAPSHOT dev 2291

Description

QuickShops seems to get stuck downloading game assets during server initialization, slowing down start-up reboot times. This happens every initialization.

[08:42:55] [Server thread/INFO]: [QuickShop] Game assets server selected: Mojang API
[08:43:15] [Server thread/INFO]: [QuickShop] No longer waiting file downloading because it now timed out, now downloading in background, please reset itemi18n.yml, potioni18n.yml and enchi18n.yml after download completed.

Steps to reproduce

  1. Start server.
  2. Look at QuickShops initialization logs.
  3. See delay for 20 seconds as game assets failed to download and timed out.

Expected Behaviour

No delay / timeout downloading assets. Alternatively don't get stuck downloading assets if they already exist or do it post-initialization?

Screenshots

Not relevant.

/qs paste URL

https://paste.helpch.at/ejotumunol

Additional Context

I have tried setting enabled-languages just to english & game-language to english. As well as deleting the 3 language files and letting it re-download. The timeout happens every single time. I'm weary about changing the download channel to a chinese mirror as I do not run a chinese server. I don't believe my server has issues contacting Mojang's official channel since the files do download if they are missing (deleted to reset) and does authenticate online connections through Mojang.

#Set the default language code the plugin should use, it will apply to:
#Item Name
#Enchantment Name,
#Potion Effect Name
#The text on the shop info sign (If NBTApi not installed)
#And other default language related text.
#Set it to default will use your system language.
#You can find the valid language code in your client language settings, like en_us
game-language: default

#Choose which languages should be enabled
#Any client connect to server that using disabled language, will fallback to game-language option there
#Set to - '*' to enable all available languages
#The language files will automatically update thorough Crowdin OTA system, you can translate it there:
#https://crowdin.com/project/[PROTECTED]-reremake
#If you want custom the language file, use language override system:
#https://github.com/PotatoCraft-Studio/QuickShop-Reremake/wiki/Use-translation-override-system
enabled-languages:
- '*'

#Setting the game language file download channel, like item name, effect translations etc.
#We will get those files from mojang resources server:
#0=Official
#1=BMCLAPI (Unofficial China Mirror, https://bmclapidoc.bangbang93.com)
#2=MCBBSMirror (Another OpenBMCLAPI Mirror, https://www.mcbbs.net)
#You can choose which one you want to use for downloading resources.
#By default, QuickShop use Mojang official server to downloading resources.
mojangapi-mirror: 0
sandtechnology commented 2 years ago

How about this version? https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2292/

sandtechnology commented 2 years ago

Fixed in 5.1.0.6