[BUG] Shulker shops drop the sign and disappear when you use a piston!

[Smudgge]

Description

When you create a QS shop with a shulker and then you use a piston to break the shulker. It drops the sign and breaks the shop.

Steps to reproduce

• Create a QS shop on a shulker
• Break it with a piston

Expected Behaviour

You are ether unable to break the shop or it does not drop a sign!

Screenshots

/qs paste URL

https://paste.helpch.at/iyowoyotas

Additional Context

No response

[sandtechnology]

Shulker will be added to shop-black-list in the next version, you can just remove it to fix it (For why I don't fix it is because there are so many container thing you can use, and it's user choice)

[sandtechnology]

Edit: look like we have enchance-shop-protect setting, which will prevent such bug, could you enable it and test again?

[Smudgge]

Hey there, I have just tested both protection config options and they do not fix the bug.

#Use enhanced display protection.
enchance-display-protect: true

#Use enhanced shop protection.
enchance-shop-protect: true

I understand shulkers can be disabled but it would be nice to be fixed as it's a shop option and stop players from duplicating signs.

[sandtechnology]

How about this build? https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2399/artifact/target/QuickShop-5.1.0.10-SNAPSHOT.jar

[Smudgge]

With that build, for some reason, i am now unable to even create a shop o:

shop-blocks:
- CHEST
- TRAPPED_CHEST
- ENDER_CHEST
- SHULKER_BOX

[sandtechnology]

SHULKER

This build should fix it: https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2402/artifact/target/QuickShop-5.1.0.10-SNAPSHOT.jar

[Smudgge]

All fixed now, thank you ❤️