search

PotatoCraft-Studio / QuickShop-Reremake

QuickShop-Reremake is a **FREE** shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop-Reremake provides are ever needed by a player.
GNU General Public License v3.0
69 stars 78 forks source link

[BUG] Circular dependencies for ArmShopBridge #316

Closed Kingie07 closed 1 year ago

Kingie07 commented 1 year ago

Description

New Paperspigot update causes Quckshop and ArmShopBridge dependancy issues.

[13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] Circular dependencies detected! > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] You have a plugin that is depending on a plugin which refers back to that plugin. Your server will shut down until these are resolved, or the strategy is changed. > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] Circular dependencies: > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] QuickShop depends on ArmShopBridge depends on QuickShop... > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] If you would like to still load these plugins, acknowledging that there may be unexpected plugin loading issues, run the server with -Dpaper.useLegacyPluginLoading=true

https://docs.papermc.io/paper/reference/paper-plugins#cyclic-dependency-detection

Steps to reproduce

PaperMC 1.19.3 #407 Plugins - Quckshop 5.1.1.3 & AdvancedRegionMarket Shop Bridge 1.2.5

Console Error & Server force crash

[13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] Circular dependencies detected! > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] You have a plugin that is depending on a plugin which refers back to that plugin. Your server will shut down until these are resolved, or the strategy is changed. > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] Circular dependencies: > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] QuickShop depends on ArmShopBridge depends on QuickShop... > [13:12:08 ERROR]: [ConfiguredOrderedProviderStorage] If you would like to still load these plugins, acknowledging that there may be unexpected plugin loading issues, run the server with -Dpaper.useLegacyPluginLoading=true

Expected Behaviour

Change dependancy according to needs of PaperMC

https://docs.papermc.io/paper/reference/paper-plugins#cyclic-dependency-detection

Screenshots

n/a

/qs paste URL

https://paste.helpch.at/ariqicacoh.md

Additional Context

No response

Issues-translate-bot commented 1 year ago

Bot detected the issue body's language is not English, translate it automatically. Please use English next time.

Title: [BUG]

Kingie07 commented 1 year ago

its english :D

sandtechnology commented 1 year ago

Should be fixed in this snapshot build, and seems bot complain about the incomplete title? https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2470/artifact/target/QuickShop-5.1.1.3-SNAPSHOT.jar

Kingie07 commented 1 year ago

Should be fixed in this snapshot build, and seems bot complain about the incomplete title? https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2470/artifact/target/QuickShop-5.1.1.3-SNAPSHOT.jar

Brilliant. Tested and working fine! Thankyou

sandtechnology commented 1 year ago

Fixed in 5.1.2.0 release