search

PotatoCraft-Studio / QuickShop-Reremake

QuickShop-Reremake is a **FREE** shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop-Reremake provides are ever needed by a player.
GNU General Public License v3.0
69 stars 78 forks source link

[BUG] "The event is Deprecated" will still be prompted when using PlayerShopClickEvent #330

Closed lRENyaaa closed 1 year ago

lRENyaaa commented 1 year ago

Description

When I tried to adapt my plugin to a new version of QuickShop, I found that PlayerShopClickEvent did not work as expected. Code: https://github.com/RenYuan-MC/QuickShopForm/blob/master/src/main/java/ren/rymc/quickshopform/QuickShopForm.java

Steps to reproduce

  1. Using PlayerShopClickEvent
  2. The server prompts "the event is Deprecated"

Expected Behaviour

PlayerShopClickEvent should not be Deprecated

Screenshots

image

/qs paste URL

https://paste.helpch.at/amehizizaf

Additional Context

No response

sandtechnology commented 1 year ago

This notice is not sent by us, and seems paper side will thinks the new event class extends deprecated event class still deprecated, so I do a change in this snapshot, it should no more notice again: https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2490/

Ref:https://github.com/PaperMC/Paper/blob/79db3a2a4bf3705fed1f04815f71493c7d00b30b/patches/server/0013-Paper-Plugins.patch#L3207-L3255

lRENyaaa commented 1 year ago

seems ok :D