search

PotatoCraft-Studio / QuickShop-Reremake

QuickShop-Reremake is a **FREE** shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop-Reremake provides are ever needed by a player.
GNU General Public License v3.0
68 stars 77 forks source link

[PERFORMANCE] Plugin Creating A Lot of Threads #430

Closed Kyrobi closed 3 months ago

Kyrobi commented 6 months ago

Description

The plugin is creating a lot of database connection threads.

Steps to reproduce

I'm not sure how it's reproduced. I was checking my spark report since the server was lagging a little bit.

Expected Behaviour

Quickshop to not create so many connection threads

Screenshots

image

/qs paste URL

https://paste.helpch.at/efemozical

Spark Sample URL

https://spark.lucko.me/bBG8Lh2qDN

Additional Context

No response

sandtechnology commented 6 months ago

spark report is unable to load, please check that

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Kyrobi @.> Sent: Monday, December 25, 2023 4:25:21 AM To: PotatoCraft-Studio/QuickShop-Reremake @.> Cc: Subscribed @.***> Subject: [PotatoCraft-Studio/QuickShop-Reremake] [PERFORMANCE] Plugin Creating A Lot of Threads (Issue #430)

Description

The plugin is creating a lot of database connection threads.

Steps to reproduce

I'm not sure how it's reproduced. I was checking my spark report since the server was lagging a little bit.

Expected Behaviour

Quickshop to not create so many connection threads

Screenshots

image.png (view on web)https://github.com/PotatoCraft-Studio/QuickShop-Reremake/assets/20980266/5d7af01d-6fb2-4119-9264-a4a0ba4b9d55

/qs paste URL

https://paste.helpch.at/efemozical

Spark Sample URL

https://spark.lucko.me/bBG8Lh2qDN

Additional Context

No response

— Reply to this email directly, view it on GitHubhttps://github.com/PotatoCraft-Studio/QuickShop-Reremake/issues/430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE3YYC6GEYHW3TMPQQKJ53TYLCFTDAVCNFSM6AAAAABBBX4ZIKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKMRQGU4DKNY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Kyrobi commented 6 months ago

Oops. Here's another one: https://spark.lucko.me/kU2cw21l8B

sandtechnology commented 6 months ago

Oops. Here's another one: https://spark.lucko.me/kU2cw21l8B

Sorry for late reply, but spark report is expired again, could you send a new report there?

Kyrobi commented 6 months ago

I've switched QS to using a different database and it's not happening again so I won't be able to generate another spark report

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.