PotatoCraft-Studio / QuickShop-Reremake

QuickShop-Reremake is a **FREE** shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop-Reremake provides are ever needed by a player.
GNU General Public License v3.0
70 stars 76 forks source link

[BUG] Players without permission for /qs removeall can see the command with /qs help #71

Closed SrBedrock closed 2 years ago

SrBedrock commented 2 years ago

Description

Players without permission for /qs removeall can see the command with /qs help

Steps to reproduce

  1. Remove quickshop.removeall, quickshop.removeall.self and quickshop.removeall.others from players.

  2. Use /qs help

Expected Behaviour

Players do not see command descriptions that they do not have permission.

Screenshots

image

/qs paste URL

https://paste.helpch.at/ofujihuzeg

Additional Context

No response

sandtechnology commented 2 years ago

https://ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2181/ How about this version?

SrBedrock commented 2 years ago

ci.codemc.io/job/PotatoCraft-Studio/job/QuickShop-Reremake-SNAPSHOT/2181 How about this version?

Solved with https://github.com/PotatoCraft-Studio/QuickShop-Reremake/commit/bf32c689d00464de8e1609f381893ead915b0ccc

image