PotatoOfDoom / CyberFSR2

FidelityFx Super Resolution 2.0 for Cyberpunk
MIT License
620 stars 67 forks source link

Use one of the quality presets for something akin to DLAA #15

Closed muddymind closed 2 years ago

muddymind commented 2 years ago

Hi!

I made a proof of concept by editing the FSR2.0 sdk to not do any upscaling and thus creating a "FSRAA". I tested it on metro exodus EE and the results are really good with the best image quality I ever got in that game while the performance is just slightly bellow native TAA.

I made a reddit post with my testing and with what I changed: https://www.reddit.com/r/pcmasterrace/comments/vt6wbm/testing_fsraa_as_a_dlaa_competitor_using_metro/?

TheRazerMD commented 2 years ago

Someone correct me if I'm wrong, but I believe the RDR2 fork also has something akin to FSAA/DLAA when you use the Ultra Quality DLSS option as you get the best image quality and lose some performance too. Great idea honestly.

mnxn commented 2 years ago

Someone correct me if I'm wrong, but I believe the RDR2 fork also has something akin to FSAA/DLAA when you use the Ultra Quality DLSS option as you get the best image quality and lose some performance too. Great idea honestly.

That's true for any game that has "Ultra Quality" DLSS. Since FSR 2.0 doesn't have a Ultra Quality preset, the mod will use native resolution:

https://github.com/PotatoOfDoom/CyberFSR2/blob/07fa62620c4132bc34c3fa96bd6472c74badc263/CyberFSR/Dx12ParameterImpl.cpp#L266-L269

Now that we have support for a configuration file, options can be added to override the resolution and allow "FSRAA" in games that don't have an Ultra Quality preset.

ronoverdrive commented 2 years ago

Does anyone know if DLAA uses the same interface as DLSS? If so any game that supports DLAA as an option you could flag it for FSRAA as well.

Jeoshua commented 2 years ago

The idea of being able to use the ini file to set the ratios is pretty awesome. I would love to play around with this and see what kind of results come from outlandish values. What would setting the values to be "lower" than 1x do?

muddymind commented 2 years ago

That's true for any game that has "Ultra Quality" DLSS. Since FSR 2.0 doesn't have a Ultra Quality preset, the mod will use native resolution

If you don't specify a valid quality preset it will fail a check in the function ffxFsr2GetRenderResolutionFromQualityMode and if a valid quality preset is passed then it will override the renderWidth and renderHeight values:

image

What would setting the values to be "lower" than 1x do?

Cursed results lol: https://youtu.be/_hHw9kcexGo

PotatoOfDoom commented 2 years ago

the newest version fixes this by allowing users to manually set an upscale ratio