PotatoOfDoom / CyberFSR2

FidelityFx Super Resolution 2.0 for Cyberpunk
MIT License
623 stars 67 forks source link

Diablo 2 Resurrected regression #42

Open aufkrawall opened 2 years ago

aufkrawall commented 2 years ago

Starting with this build https://github.com/PotatoOfDoom/CyberFSR2/actions/runs/2888774513 it seems the image isn't reconstructed correctly anymore, it's super blurry and camera jitter is observable: D2R_2022_09_17_19_18_33_190

The same applied to RDR2 prior to #41 , which fixed it in that game. Earlier builds work in D2R, albeit with bad ghosting.

Some side note mentions:

MOVZX commented 2 years ago

RDR2 previously doesn't have FSR built-in. And ever since they added FSR into the game, CyberFSR doesn't work like previously when RDR is still 1436.31 and FSR is still 2.0 because the way TAA works on RDR2 also changed (improved, Rockstar said).

CyberFSR 0.8.0-beta2 breaks some games, but it helped UE4 games a lot because before 0.8.0-beta2 there's severe shimmering and christmas light effect on every UE4 games, 0.8.2-beta2 fixed that issue. 0.8.0-beta2 also fixed ghosting on HZD drastically.

MOVZX commented 2 years ago

UPSCALING OFF

Upscaling OFF

UPSCALING ON (CyberFSR with FSR 2.0 taken from here: https://github.com/PotatoOfDoom/CyberFSR2/actions/runs/2855966575 but with correct ViewMatrixHook for 1491.16)

CyberFSR ON with correct ViewMatrixHook

UPSCALING ON (CyberFSR with FSR 2.0 taken from here: https://github.com/PotatoOfDoom/CyberFSR2/actions/runs/2855966575 but without correct ViewMatrixHook for 1491.16)

CyberFSR ON but with wrong ViewMatrixHook

COMPARISON SLIDER

https://imgsli.com/MTI2MDE3/1/2

MOVZX commented 2 years ago

Starting with this build https://github.com/PotatoOfDoom/CyberFSR2/actions/runs/2888774513 it seems the image isn't reconstructed correctly anymore, it's super blurry and camera jitter is observable: D2R_2022_09_17_19_18_33_190

The same applied to RDR2 prior to #41 , which fixed it in that game. Earlier builds work in D2R, albeit with bad ghosting.

Some side note mentions:

* NM CyberFSR 0.8.0-beta2 crashes Dying Light 2, latest stable or GitHub action build still works

* CyberFSR2 also works in Hitman 3, but only with VKD3D-Proton (black screen with native D3D12)

By looking at the picture, it's a sign that you need to define proper FOV values. Let's hope someone who owns the game can make a PR and add proper ViewMatrixHook for Diablo II.

image

Some games works good without setting FOV values in nvngx.ini, but some may be broken.

aufkrawall commented 2 years ago

In Hitman 3, the ghosting reductions by 0.8.0-beta2 and 3 seem to introduce some temporal instability/blur when the screen content changes a lot (e.g. 180° camera turns), foliage in the level Whittleton Creek is affected a lot: hitman3_2022_09_19_15_31_42_171

It is much more stable with 0.7.6. But it definitely ghosts less than 0.7.6 with moving objects in front of some structures.

yasink21 commented 2 years ago

@aufkrawall Hello, I would like to ask about the version of VKD3D-Proton you use with hitman 3, my experience with other games is exactly the same RDR2, and other DLSS2FSR games, but I never get visuals on hitman 3 with fsr, only ui and black screen.

aufkrawall commented 2 years ago

Upstream stable and git-master should work. You might have to use RADV Linux with Radeon until amdvlk/Windows driver supports VK_EXT_mutable_descriptor_type (which hopefully will be soon).

yasink21 commented 2 years ago

Thanks for the information, the problem I have seems to be nvidia related then, I tried on latest stable and vulkan dev drivers. Running GTX 1070TI.