PotatoOfDoom / CyberFSR2

FidelityFx Super Resolution 2.0 for Cyberpunk
MIT License
620 stars 67 forks source link

Support for Vulkan DLSS games? #6

Closed oscarbg closed 2 years ago

oscarbg commented 2 years ago

Hi, thanks for your work! seeing people are trying to use your mod on other DLSS games like RDR2.. but seeing your mod started for Cyberpunk which is a DX12 game I guess support for native Vulkan games using DLSS will require some work, right? I mean games like: DOOM Eternal, No Man’s Sky, and Wolfenstein: Youngblood. At least FSR 2.0 code drop seems to have Vulkan support also so can eventually be added to your DLSS2FSR2 wrapper as I may call it :-) hope someone wants to work on it..

RealIndica commented 2 years ago

Check out my fork of this project, it supports Vulkan.

mnxn commented 2 years ago

Great work @RealIndica!

Any chance you can make a PR for adding Vulkan support to this repository?

RealIndica commented 2 years ago

Great work @RealIndica!

Any chance you can make a PR for adding Vulkan support to this repository?

I would love to, but I have no idea how to create another fork due to already having my RDR2 fork here.

PotatoOfDoom commented 2 years ago

Don't worry. I can add it myself. It doesn't seem too complicated.

RealIndica commented 2 years ago

Don't worry. I can add it myself. It doesn't seem too complicated.

It's not but you might find game-dependent issues with ffxGetTextureResourceVK when trying to load an FfxResource to a dispatch parameter when the arguments for the ffxGetTextureResourceVK are invalid/null; it will just crash on EvaluateFeature. That's why for transparencyAndComposition a null FfxResource is used. RDR2 doesn't seem to have transparencyAndComposition for Vulkan 🤷

SpaceGoat04 commented 2 years ago

Check out my fork of this project, it supports Vulkan.

Does your fork work on other titles like this mod or was it built specifically for RDR2 and therefore only works on it? Great work btw

RealIndica commented 2 years ago

Check out my fork of this project, it supports Vulkan.

Does your fork work on other titles like this mod or was it built specifically for RDR2 and therefore only works on it? Great work btw

PotatoOfDoom has added Vulkan to this version now so should work in Vulkan games.