PotatoOfDoom / CyberFSR2

FidelityFx Super Resolution 2.0 for Cyberpunk
MIT License
615 stars 66 forks source link

manually built dll does not take effect #74

Open juzi5201314 opened 1 year ago

juzi5201314 commented 1 year ago

I tried 3 dlls 1, downloaded from nexusmods, it works as expected. ~4mb size 2, Artifact compiled from this repository github action, not working (no dlss option), ~5mb size 3, Compile on my pc, the same steps as the github action, can not work (no dlss option), ~ tens of kb size

What did I miss?

moaazassali commented 7 months ago

Did you figure it out? I also tried the nexusmods ones, and it worked fine. However, when I compile it locally, I end up with a 209KB nvngx.dll file. I copy this file along with the two other DLLs from FidelityFX folder into cyberpunk and nothing happens in-game as it seems like regular DLSS is still running.

UPDATE: I found the issue, both the ffx_fsr2_api_dx11_x64.dll and ffx_fsr2_api_vk_x64.dll files also have to be moved along with the other 2 DLL files that are mentioned and then the mod will work. I am not sure why, but my guess is that since the compiled file has #include of the respective header files for DX11 and Vulkan (under framework.h), then the mod silently crashes or something as it can't find those references when launching the game.