search

PotatoProject / Leaflet

POSP official notes app, soon to be included
https://potatoproject.co
MIT License
355 stars 56 forks source link

issue with versionCode of v2.0.0 #67

Open IzzySoft opened 3 years ago

IzzySoft commented 3 years ago

The APK attached to the v2.0.0 release has versionCode: 20, while the older ones had a 4-digit versionCode. Hence Android will refuse to accept v2.0.0 as update. Is that intended? If one wants to update from e.g. 1.5.2 (versionCode: 2015) one has to uninstall and re-install, as Android won't permit the "downgrade" (you can increase versionCode as much as you like, but you can never decrease it).

My guess is that you've now attached a universal APK only, while before you provided arch specific ones. That makes v2.0.0 exceed the size limit for my repo btw (where your app is currently listed), so I'd have to stop updates and revert back to 1.5.2 anyway. May I suggest you add the armeabi-v7 APK as well, which then would most likely fix both issues (versionCode: 2020 and size around 10M)?

HrX03 commented 3 years ago

The main issue is flutter being trash with version numbers with the split-per-abi option which adds a 2000 to the real build number. But yes, i can provide the older split-per-abi apks with no issue, will provide asap

IzzySoft commented 3 years ago

That was fast! Thanks a lot! And yes, Flutter has its "dark sides". I was just about to disable updates for now, so I roll that back as soon as the armeabi APK is available.

IzzySoft commented 3 years ago

OK, fixed it up for my updater now: pinned it to /armeabi-v7a/i in the file name, so it will ignore the universal APK. Hence I don't have to disable updates – but your split APKs will be picked up as soon as they're available.

Btw, if you wish to place another badge next to Google's: here is mine :smile: