No 'path' in directory metadata

Potherca / flysystem-github

Flysystem adapter for Github.

MIT License

12 stars 6 forks source link

No 'path' in directory metadata #14

Open spwilson806 opened 8 years ago

spwilson806 commented 8 years ago

The metadata provided for a directory entry doesn't contain a path entity. My interpretation of the flysystem doc (http://flysystem.thephpleague.com/creating-an-adapter/) is that this can be expected. Am I reading that correctly?

Potherca commented 8 years ago

You are reading it correctly, it should be present in the metadata. Looks like I missed a spot... I'll investigate and fix this ASAP.

spwilson806 commented 8 years ago

Cool, thanks. This is what I'm specifically referring to: https://github.com/Potherca/flysystem-github/blob/develop/src/Api.php#L228

Potherca commented 8 years ago

Looks like I forgot to actually use Api::getTreeMetadata() after refactoring it.

In my timezone it's turning into night, I'll fix this in the morning.