search

Pottus / Texture-Studio

83 stars 90 forks source link

Switching To Streamer v2.9.4 #116

Closed erfanasbari closed 4 years ago

erfanasbari commented 4 years ago

Hi, @Crayder I Found A Solution To fix OnPlayerEditDynamicObject Not Being Called At Streamer v2.9.4.

By Just Adding

public OnPlayerEditObject(playerid, playerobject, objectid, response, Float:fX, Float:fY, Float:fZ, Float:fRotX, Float:fRotY, Float:fRotZ) return 0;

At This Line Before OnPlayerEditDynamicObject And It Fixes The Problem !!! ( I don't know why but it fixed it)

Looks Like Last Fix For Server Crash Was Not Working If 3 Players Use Commands. I Just Tested It With Two Clients ( Using Multi M )

It Will Be a Good Idea To Remove /MakeBind From TS Because It's Not A Necessary Command ( you can use bind system using /bindeditor )

I Personally use Ultimate SA-MP Key Binder.

Removing it is Better Than Crashing When You want to create maps with your friends.

If You Agree With That I Can Make A PR Including Streamer v2.9.4 And OnPlayerEditDynamicObject Fix And Removing /makebind

Thank you for your work ;D

Crayder commented 4 years ago

I'd prefer not to remove the bind commands totally. I prefer that and have additional macros set up for those commands even. Are you having issues with those commands?

But yeah dude if you wanna go ahead and make a PR!

erfanasbari commented 4 years ago

Are you having issues with those commands?

I Don't Have Issue with Bind commands. The Issue is that /Makebind uses new CommandBuffer[MAX_PLAYERS][MAX_COMMAND_BUFFER][128]; From cmdbuffer.pwn And When The server wants to store cmds inside CommandBuffer the server crashes (Even if i don't use bind commands ) !

The Only solution right now is removing cmdbuffer.pwn. And /Makebind is not going to work if we do that so we have to remove /makebind too.

I'd prefer not to remove the bind commands totally.

Other bind commands are good and there is no need to remove Them And The Player Still can make binds using /bindeditor command

erfanasbari commented 4 years ago

I made a PR. instead of removing /makebind and cmdbuffer.pwn i commented them in case of if someone finds a solution in the future.

i also fixed the bug when you can't select an object with a higher group id than 50 ( run time error in CanSelectObject ). and i added a check to /ogroup to check if the object id is less than 0 or higher than MAX_GROUPS. i tried to push the group limits to 1000 but /ogroup command will be too slow if i do that ( 500ms somtimes ) so i push the limits to 200 Groups.

Now anyone can change the limit just by changing MAX_GROUPS to a higher value and there will be no problems