bug fix toggle column not working on first time toogling

Power-Components / livewire-powergrid

⚡ PowerGrid generates modern, powerful and easy-to-customize data tables using Laravel Livewire.

https://livewire-powergrid.com

MIT License

1.42k stars 209 forks source link

bug fix toggle column not working on first time toogling #1431

Closed jhonoryza closed 5 months ago

jhonoryza commented 5 months ago

Motivation

[x] Bug fix
[ ] Enhancement
[ ] New feature
[ ] Breaking change

Description

bug fix toggle column not working on first time toogling after refresh browser

https://github.com/Power-Components/livewire-powergrid/assets/5910636/b845ec13-c26d-4a24-bcd0-c56f36d1b57e

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

[ ] Yes
[x] No
[ ] I have already submitted a Documentation pull request.

jhonoryza commented 5 months ago

is there a reason why make $visibleColumns as read only property ?

i try this simple example

got error: Indirect modification of overloaded element of Illuminate\Support\Collection has no effect in /var/www/html/vendor/laravel/framework/src/Illuminate/Collections/helpers.php on line 124

luanfreitasdev commented 5 months ago

Thank you @jhonoryza !

I have fixed the phpstan error