refix toogle column weird bug change to columns property - Githubissues

Power-Components / livewire-powergrid

⚡ PowerGrid generates modern, powerful and easy-to-customize data tables using Laravel Livewire.

https://livewire-powergrid.com

MIT License

1.42k stars 209 forks source link

refix toogle column weird bug change to columns property #1439

Closed jhonoryza closed 5 months ago

jhonoryza commented 5 months ago

Motivation

[x] Bug fix
[ ] Enhancement
[ ] New feature
[ ] Breaking change

Description

i think there is still bug when using this fix #1431

https://github.com/Power-Components/livewire-powergrid/assets/5910636/95e5d058-0792-4df1-bd6c-caefa0e81077

and i found that visibleColumns is computed property here

so its valid that it should be read only property

so i suggest this fix using your original solution with a little change to use columns property

sorry on the confusion on the last PR :)

Related Issue(s): #1431

Documentation

This PR requires Documentation update?

[ ] Yes
[x] No
[ ] I have already submitted a Documentation pull request.