search

Power-Maverick / PCF-CustomControlBuilder

XrmToolBox Plugin for building and deploying custom control using PCF
MIT License
40 stars 6 forks source link

Power Apps CLI not detected on this machine #34

Closed ihocan closed 3 years ago

ihocan commented 3 years ago

Describe the bug When PCF Builder oppened this issue comes, i installed Power Apps CLI pac command are working on CMD.

To Reproduce Steps to reproduce the behavior:

  1. Power Apps CLI install
  2. Open Tools on Xrm Toolbox

Screenshots image image

Desktop (please complete the following information):

power-maverick-bot[bot] commented 3 years ago

I am Groot!! Thanks for opening your first issue here! Please make sure you have given us as much context as possible. One of the Avengers will respond as soon as possible.

github-actions[bot] commented 3 years ago

Thank you for creating your first issue. This will help me improve this tool.

Power-Maverick commented 3 years ago

Did you install it after opening PCF Builder or before? Are you still getting this error?

power-maverick-bot[bot] commented 3 years ago

I am Groot!! I detected a negative sentiment. (score:-0.125) Please be respectful of other users while commenting. cc/ @Power-Maverick

xvisionbelgium commented 3 years ago

Did you install it after opening PCF Builder or before? Are you still getting this error?

Hi, I'm having the same issue.

Fresh install of the Tool. Also version 1.4.4 of PowerApps CLI pac command works on the command line and in powershell

power-maverick-bot[bot] commented 3 years ago

I am Groot!! I detected a negative sentiment. (score:-0.020833333333333332) Please be respectful of other users while commenting. cc/ @Power-Maverick

ihocan commented 3 years ago

@Power-Maverick actually i found the issue, it's related by CheckPacVersion method in MainPluginControl.cs at line 713, code is checking the "version" text in output, but as you see in my first message output is difrrent language at my computer, it's showing "Sürüm" instant of "version".

https://github.com/Power-Maverick/PCF-CustomControlBuilder/blob/814c7244642ad72f2439bdf882aa148a1b42c37e/Maverick.PCF.Builder/MainPluginControl.cs#L713

ihocan commented 3 years ago

@xvisionbelgium i think pac commands showing diffrent text on your computer also, maybe local language?

Power-Maverick commented 3 years ago

I'll get it fixed soon. Sorry for this annoying bug. Wish there was a better way to detect if Power Apps CLI is installed on the machine other than evaluating the output of the pac command. Any ideas are welcomed.

xvisionbelgium commented 3 years ago

Hi

Probably Mine is giving output in Dutch (local language)

PS C:\Users\JohanH.XV-JHW7-PC> pac Microsoft PowerApps CLI Versie: 1.4.4+g0574e87

Gebruik: pac [auth] [help] [org] [package] [pcf] [plugin] [solution] [telemetry]

auth Beheren hoe u bij verschillende services verifieert help Help voor de Microsoft PowerApps CLI weergeven org Werken met uw CDS-organisatie package Opdrachten voor het werken met CDS-pakketprojecten pcf Opdrachten voor werken met PowerApps component framework-projecten plugin Opdrachten voor werken met klassebibliotheek voor CDS-invoegtoepassingen solution Opdrachten voor het werken met CDS-oplossingsprojecten telemetry Telemetrie-instellingen beheren

Launcher usage: pac [install] [use]

install <version# | latest> Install 'latest' or a specified version of the Microsoft PowerApps CLI use <version# | latest> Use 'latest' or a specified version of the Microsoft PowerApps CLI

From: ihocan notifications@github.com Sent: donderdag 4 februari 2021 16:18 To: Power-Maverick/PCF-CustomControlBuilder PCF-CustomControlBuilder@noreply.github.com Cc: Johan Hamelinck (XV) johanh@xvision.be; Mention mention@noreply.github.com Subject: Re: [Power-Maverick/PCF-CustomControlBuilder] Power Apps CLI not detected on this machine (#34)

@xvisionbelgiumhttps://github.com/xvisionbelgium i think pac commands showing diffrent text on your computer also, maybe local language?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Power-Maverick/PCF-CustomControlBuilder/issues/34#issuecomment-773385803, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIWYDZ4SHF27U5TFQZG5TQTS5K3DFANCNFSM4WA6635Q.

Power-Maverick commented 3 years ago

Working on the fix. Will test it with a non-English machine and release the fix soon.

Power-Maverick commented 3 years ago

Tagging @carfup for visibility.

ihocan commented 3 years ago

@Power-Maverick Maybe you can use "Get-Command" with powershell it's return detail about command, i didn't find any good script when i check for CMD.

image

Power-Maverick commented 3 years ago

@ihocan that doesn't give me the version of the CLI installed on the machine.

Power-Maverick commented 3 years ago

Issue is now fixed in 2.2021.02.052 version. For a non-English language I won't be able to find the CLI version but at least you should not get a prompt if CLI is installed. And if everything goes south; the tool wont force close itself.