search

Power-Maverick / PCF-CustomControlBuilder

XrmToolBox Plugin for building and deploying custom control using PCF
MIT License
39 stars 6 forks source link

[Bug]: Build All and Deploy doesn't deploy on German system (MSBuild is in German) #67

Open didschai opened 1 year ago

didschai commented 1 year ago

Contact Details

No response

What happened?

After clicking "Build all and deploy" the build finishes, but the solution is not deployed to Dynamics. After checking the source code (PCFBuilder.cs, line 2206), I saw there is a check prior to publishing: CurrentCommandOutput.ToLower().Contains("done building project") However, if the system language MSBuild runs on is in German, the check fails. The log output on my machine is:

image

I modified the condition to be: if (BuildDeployExecution && lblStatus.Text.ToLower().Equals("succeeded") && (CurrentCommandOutput.ToLower().Contains("done building project") || CurrentCommandOutput.ToLower().Contains("erfolgreich"))) and it works fine. Don't know if there is a better way of handling this..

Regards, Denis

What version of the tool are you using?

2.2023.6.162

What version of XrmToolBox are you running?

1.2023.6.65

Relevant log output

No response

power-maverick-bot[bot] commented 1 year ago

Thanks for opening your first issue here! Please make sure you have given us as much context as possible. One of the repo maintainer will respond as soon as possible.

github-actions[bot] commented 1 year ago

Thank you for creating your first issue. This will help me improve this tool.