Closed ArturNawrocki closed 3 years ago
Hello, it’s ok. I’m new to Github. Should I commit this name change?
On Fri, 8 Oct 2021 at 15:40, Dan Meissner @.***> wrote:
Suggest renaming this script to be consistent with existing script that replaces text in the expression itself. "Replace Text Strings that appear in many measures.csx"
Two scripts, one "Replace Text Strings that appear in any Measure Expression.csx" (existing one) and "Replace Text Strings that appear in any Measure Name.csx"
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/PowerBI-tips/TabularEditor-Scripts/pull/2#issuecomment-938651830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7DA3XMAVIUR3TSEMPPEY3UF3YD5ANCNFSM5FTI2ABQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
No problem, I'm rather new myself. No need to change the name of the existing one (replace in expression). I put that in my fork. If you just rename yours to my note above (Replace Text Strings that appear in any Measure Name.csx) that will add clarity.
Suggest renaming this script to be consistent with existing script that replaces text in the expression itself. "Replace Text Strings that appear in many measures.csx"
Two scripts, one "Replace Text Strings that appear in any Measure Expression.csx" (existing one) and "Replace Text Strings that appear in any Measure Name.csx"