search

PowerBroker2 / ArduPID

PID library for Arduinos with greater accuracy than the legacy Arduino PID library
MIT License
85 stars 23 forks source link

fix negative integral windup limits #7

Closed shiukaheng closed 1 year ago

shiukaheng commented 1 year ago

Fix for #5

Researcherdynamics commented 1 year ago

Fix for #5

Thank you, it works

PowerBroker2 commented 1 year ago

Thank you for the PR, but I'm starting to wonder if this fix will continue to work if outputMin is positive. Perhaps a more complex solution is needed? Been a while since I've looked at this lib so external input is more than welcome

PowerBroker2 commented 1 year ago

I'll just merge now and fix later if it's an issue

shiukaheng commented 1 year ago

Sorry, busy with work atm, I will test it out later with positive outputMin values to see if it works fine :)