PowerDNS / lightningstream

Lightning Stream syncs LMDB databases through S3 buckets between multiple servers, including PowerDNS Authoritative server 4.8+ LMDBs
https://doc.powerdns.com/lightningstream/
MIT License
25 stars 15 forks source link

Check spelling updates #47

Closed jsoref closed 1 year ago

jsoref commented 1 year ago

This is a bundle of fairly unrelated things.

Note that the commit messages for some of these changes are incredibly long.

The m_data comment update corresponds to this: https://github.com/check-spelling/spell-check-this/commit/4f81233290253fc998a6ce3e9fe7b638d672dd86 @Habbie asked me if I knew where it came from, and at the time it was written, I didn't, it was just something that was mentioned by https://github.com/nasa/fprime as a thing they'd like to be able to handle (https://github.com/nasa/fprime/discussions/855). It turns out their repository actually did indicate which vendor had the issue (https://github.com/nasa/fprime/commit/aa4cb0006fd6d8abae086d521fb5fa70d9ee7f66), but I didn't check for that and merely noted it as a theoretical case. I've now updated the check-spelling wiki entry to provide more information about its pedigree.

The expect updates would be triggered the next time someone introduced a misspelling, but since I'm already making a PR, I'm bundling it here. (They're mostly the result of #44's changes which excluded checking the .github/workflows directory.) Fwiw, this is a conscious tradeoff. check-spelling aims for a form of "eventual consistency". It's more or less ok to temporarily have a couple of stray expected items as they'll be cleaned up the next time someone tries to add an unexpected word. If there's ever a case where you really don't want a word coming in, you can use the forbidden feature (as m_data could be -- see above).