Consistency: domain type compared case sens./case insens.

PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist

https://www.powerdns.com/

GNU General Public License v2.0

3.67k stars 906 forks source link

Consistency: domain type compared case sens./case insens. #1035

Open zeha opened 11 years ago

zeha commented 11 years ago

PowerDNS internally uses case insensitive comparison for the domains.type field. The default queries use "=" comparison, no matter what database is used. Depending on the database and configuration, this might be a case sensitive comparison.

Habbie commented 11 years ago

There's a lot of toLower going around, but I'm sure we missed a few!

zeha commented 11 years ago

Example:

declare(suffix,"master-zone-query","Data", "select master from domains where name='%s' and type='SLAVE'");

Habbie commented 11 years ago

Indeed, missing there

Habbie commented 11 years ago

My earlier comments were about names, not types. Still a valid ticket I think.

zeha commented 11 years ago

thoughts from IRC:

I feel that pdns should actively reject wrongly-capitalized types
the same issue likely exists with record types
working around that will likely be a perf pain

Habbie commented 11 years ago

I agree. Being strict would be good here. Can probably enforce that with triggers/constraints in most database schemas (and adding those to our schema files is fine).

p53 commented 7 years ago

i had recently problem with this and it was quite pain to find problem, axfr was working, manual notifies were working, but notify after dnsupdate was not, because i had master in type not MASTER...., i wouldn't think such thing would break functionality..., i use postgres