search

PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.47k stars 885 forks source link

auth: weird launch line in (el7) RPM #14282

Open Habbie opened 3 weeks ago

Habbie commented 3 weeks ago

The pdns.conf we install contains # launch=\nlaunch=. A user reported this on 4.9.1, but I found it goes back to at least 4.5.0.

micheloe commented 6 days ago

I can confirm this. The issue appears to be in builder-support/pdns.spec on line 233: https://github.com/PowerDNS/pdns/blob/a376dc3be9716f580ba4377bafa440ba66a952f4/builder-support/specs/pdns.spec#L233

The sed script has two backslashes for the newline character. Removing this solves the issue on EL7. I'm not sure what the behaviour is on other EL versions though.

diff --git a/builder-support/specs/pdns.spec b/builder-support/specs/pdns.spec
index ae5db16d1..c0b52a745 100644
--- a/builder-support/specs/pdns.spec
+++ b/builder-support/specs/pdns.spec
@@ -230,7 +230,7 @@ make install DESTDIR=%{buildroot}
 %{buildroot}/usr/sbin/pdns_server --config=default | sed \
   -e 's!# daemon=.*!daemon=no!' \
   -e 's!# guardian=.*!guardian=no!' \
-  -e 's!# launch=.*!&\\nlaunch=!' \
+  -e 's!# launch=.*!&\nlaunch=!' \
   -e 's!# setgid=.*!setgid=pdns!' \
   -e 's!# setuid=.*!setuid=pdns!' \
   > %{buildroot}%{_sysconfdir}/%{name}/pdns.conf