search

PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.67k stars 907 forks source link

bind backend chokes on file directive inside a logging channel clause #2290

Open bhourigan opened 9 years ago

bhourigan commented 9 years ago

The bind backend can't handle the following snippit from my named.conf, citing an error with the 'file' directive:

logging {
        channel default_debug {
                file "data/named.run";
                severity dynamic;
        };
};

Going by the bind backend documentation I expect the backend to ignore everything other than zone statements. I get that impression from the following text:

The BindBackend parses a Bind-style named.conf and extracts information about zones from it. It >makes no attempt to honour other configuration flags, which you should configure (when available) >using the PDNS native configuration.

Running 3.4.2 x86_64, build information below:

Mar  1 10:58:07 dns1 pdns[26836]: PowerDNS Authoritative Server 3.4.2 (jenkins@autotest.powerdns.com) (C) 2001-2015 PowerDNS.COM BV
Mar  1 10:58:07 dns1 pdns[26836]: Using 64-bits mode. Built on 20150203085339 by root@autotest.powerdns.com, gcc 4.7.2.
mallardduck commented 2 years ago

I've recently come across this while trying to migrate data and config files off of a WHM/cPanel server. The fact that this issue is so old and that WHM has used PowerDNS as a default since 2018 seems a bit odd to me. As the fact that the config I'm migrating was created on WHM for powerDNS, this would imply that WHM's package of pdns supports this config.

Granted I could be very wrong with my recollection of how the license should work. And I probably am wrong. However it just seems odd that there's potential WHM has a patch for this issue, yet they haven't provided it here to the upstream. Again I'm probably a bit off on my understanding of the GLP here since IANAL. Even if I am right I shouldn't be surprised by for profit companies using open-source and not contributing to it.

EDIT: TBH since I'm just 1:1 migrating configs as a temporary stop gap, I'm just going to remove this section of the named.conf. While it'd be neat to dig into why cPanel seems to support this feature, it's more productive to move on to my next tasks. I suspect other users hoping to use the bind-backend may have different needs, but for me removing them is sufficient.

Habbie commented 1 year ago

However it just seems odd that there's potential WHM has a patch for this issue, yet they haven't provided it here to the upstream.

The GPL only requires WHM to offer the modified source to the customers that bought their version of PowerDNS. The GPL sadly does not require upstreaming of patches.