PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.67k stars 907 forks source link

remote back-end: inconsistencies in documentation vs code #2857

Open jpmens opened 8 years ago

jpmens commented 8 years ago

version 3.4.7

I'm seeing some inconsistencies in what is documented for the remote backend.

startTransaction

The documentation says: Parameters: domain_id, domain, trxid My program is not given a domain. Also: what could be clarified is where the domain_id stems from and/or what -1 means. (I assume "we don't yet know what the domain_id is").

With

pdnssec secure-zone b1.aa

my program gets

"POST /startTransaction/-1//1446625121 HTTP/1.1"

I was expecting /startTransaction/-1/b1.aa/1446625121

removeDomainKey

The documentation says: Parameters: name, id pdnssec built-in help says: Syntax: pdnssec remove-zone-key ZONE KEY-ID

With

pdnssec remove-zone-key b1.aa 92

My program gets:

"DELETE /removeDomainKey/92/b1.aa HTTP/1.1"

(i.e. ZONE and key-id are swapped)

pieterlexis commented 7 years ago

I was expecting /startTransaction/-1/b1.aa/1446625121

current master does this

(i.e. ZONE and key-id are swapped)

This is still the case in master. This because we insert id as first element. Some other HTTP urls require the ID first (like setNotified). We can either cahnge the docs, or rename this id to keyid.@cmouse: opions?

cmouse commented 7 years ago

in fact it seems that startTransaction got empty value where it was supposed to get domain (see how it has // instead of /).

i'll see what can be done to these.