PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.63k stars 904 forks source link

tarball missing (js) sources #3118

Open zeha opened 8 years ago

zeha commented 8 years ago

Auth (in order of importance):

Recursor:

dnsdist:

pieterlexis commented 8 years ago

missing source files for

  • docs/markdown/theme/js/bootstrap-3.0.3.min.js
  • docs/markdown/theme/js/prettify-1.0.min.js

These were (are) grabbed as-is from the mkdocs themes. I could add a small readme/license file.

zeha commented 8 years ago

@pieterlexis please do, also debian needs the unminified sources, too.

pieterlexis commented 8 years ago

mkdocs doesn't ship the un-minified sources :disappointed:

zeha commented 8 years ago

missing source files for

  • docs/markdown/theme/js/bootstrap-3.0.3.min.js
  • docs/markdown/theme/js/prettify-1.0.min.js

These were (are) grabbed as-is from the mkdocs themes. I could add a small readme/license file.

Just looked at docs/markdown/theme/css/bootstrap-custom.min.css, and I'm thinking shipping source for that is either hopeless or a very enterprisey task. Would you be ok with rearranging the prebuilt sources into a vendor/ folder? That way I can just exclude them when importing your tarballs and symlink in the files from the libjs-bootstrap package (OTOH this means following major version upgrades in a timely manner, I think).

pieterlexis commented 8 years ago

Updated the list, only the javascript issues remain.

rubenk commented 8 years ago

The checklist says this is done for the recursor, but pdns-recursor-4.0.0-alpha2.tar.bz2 still contains minified javascript files.

rubenk commented 8 years ago

IANAL, but can we mention something somewhere about the license of those files?

rubenk commented 8 years ago

The jquery in recursordistdist is 1.8.3, which is unmaintained, and has some vulnerabilities.

zeha commented 8 years ago

recursor tarball now also misses sources for html/js/*.js

zeha commented 8 years ago

if you want to make my life easier, please supply sources along the minified files, so f.e. have moment.js next to moment.min.js :)

zeha commented 8 years ago

Working on the mkdocs theme here: https://github.com/zeha/pdns/tree/doc-js

zeha commented 8 years ago

As discussed Yesterday over lunch, removing the mkdocs theme from the tarball might be the easiest option.

pieterlexis commented 8 years ago

@zeha I think the recursor is fixed with #3981?

zeha commented 8 years ago

I think so.