PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.69k stars 907 forks source link

secure-delegated test zone has been broken since CSK switch #3591

Closed Habbie closed 8 years ago

Habbie commented 8 years ago
[2016-03-17 11:07:55] Added a ZSK with algorithm = 8, active=0
[2016-03-17 11:07:55] Requested specific key size of 1024 bits
[2016-03-17 11:07:55] Syntax: pdnsutil activate-zone-key ZONE KEY-ID
[2016-03-17 11:07:55] Adding NSEC ordering information
[2016-03-17 11:07:56] Securing zone with default key size

This relates to https://github.com/PowerDNS/pdns/blob/master/regression-tests/start-test-stop#L79

Apparently tests are passing even with this error, need to figure out why. This only came to light because one test suddenly said [2016-03-17 11:19:40] Invalid KEY-ID '=', presumably because the base64 of a DNSKEY literally contained 'ZSK' and the wrong line got picked & split.

pieterlexis commented 8 years ago

These tests passed because the records were signed correctly using the CSK (that was imported as KSK on line 78). The ZSK was never activated, so the KSK acted as CSK.

pieterlexis commented 8 years ago

patch coming tomorrow