Open ncraike opened 5 years ago
The Lua scripting examples in the wiki appear to all use the old scripting API from version 3.X instead of the latest 4.1 hooks API.
The Lua scripting examples in the wiki look genuinely great and helpful, but they appear to all use the old scripting API from version 3.X instead of using the latest 4.1 hooks with the DNSQuestion object.
DNSQuestion
For example, the "the.time" example defines:
function preresolve ( remoteip, domain, qtype )
when the latest hooks documentation documents the signature as preresolve(dq).
preresolve(dq)
I would love to update the wiki directly myself, but I'm just getting started with Lua scripting, so I'm not 100% across all the API changes since 3.X, and I'm not sure how to re-test the examples once I've updated them.
This needs labels docs and rec.
docs
rec
Short description
The Lua scripting examples in the wiki appear to all use the old scripting API from version 3.X instead of the latest 4.1 hooks API.
Description
The Lua scripting examples in the wiki look genuinely great and helpful, but they appear to all use the old scripting API from version 3.X instead of using the latest 4.1 hooks with the
DNSQuestion
object.For example, the "the.time" example defines:
when the latest hooks documentation documents the signature as
preresolve(dq)
.I would love to update the wiki directly myself, but I'm just getting started with Lua scripting, so I'm not 100% across all the API changes since 3.X, and I'm not sure how to re-test the examples once I've updated them.