PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.72k stars 914 forks source link

geoipbackend: no previous declaration for validateMappingLookupFormats #9791

Closed zeha closed 4 years ago

zeha commented 4 years ago

Short description

Environment

Steps to reproduce

  1. try a debian build
  2. observe the warning emitted by gcc

Actual behaviour

geoipbackend.cc:99:6: warning: no previous declaration for ‘bool validateMappingLookupFormats(const std::vector<std::__cxx11::basic_string<char> >&)’ [-Wmissing-declarations]
   99 | bool validateMappingLookupFormats(const vector<string>& formats) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Other information

g++ (Debian 10.2.0-19) 10.2.0
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../.. -pthread   -I/usr/include/ -I/usr/include/x86_64-linux-gnu -Wdate-time -D_FORTIFY_SOURCE=2  -fPIE -DPIE -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 --param ssp-buffer-size=4 -fstack-protector -std=c++11 -g -O2 -Wall -Wextra -Wshadow -Wno-unused-parameter -Wmissing-declarations -Wredundant-decls -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DPACKAGEVERSION='"4.4.0~beta1-1.Debian"' -c -o geoipbackend.lo geoipbackend.cc
Habbie commented 4 years ago

function should be made static