search

PowerDNS / weakforced

Anti-Abuse for servers at authentication time
GNU General Public License v3.0
123 stars 33 forks source link

Use OpenResty Luajit Package with wforce #425

Closed neilcook closed 2 months ago

neilcook commented 2 months ago

Regular luajit provided with many distros has memory allocation issues that causes crashes. These issues are fixed in the OpenResty fork of LuaJIT. This PR packages up the OpenResty fork of LuaJIT, and compiles wforce against. The luajit package also include various lua modules that are interesting and useful for wforce such as luasec, elasticsearch and lualdap. Such modules are often only available as packages for later versions of Lua, not Lua 5.1 which is what LuaJIT requires.

This PR also adds support for debian bookworm and drops support for debian buster.

General tidying of the packaging dockerfiles is also part of the PR in order to take better advantage of docker caching/multi-stage builds to improve performance.

github-actions[bot] commented 2 months ago

Test Results

  2 files  ±0    2 suites  ±0   32m 9s :stopwatch: -4s  70 tests ±0   70 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  140 runs  ±0  140 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 4bde3485. ± Comparison against base commit 97ef80a8.

:recycle: This comment has been updated with latest results.

neilcook commented 2 months ago

halfway through I realised you checked in more than you intended, so I'll continue my review when you cleaned up

Yes thanks, I didn't run cleanup.sh after a local testing run...

Habbie commented 2 months ago

Yes thanks, I didn't run cleanup.sh after a local testing run...

a bit of .gitignore can prevent future accidents

neilcook commented 2 months ago

Indeed, will do this before I merge,

Neil

On 7 Jun 2024, at 11:53, Peter van Dijk @.***> wrote:

Yes thanks, I didn't run cleanup.sh after a local testing run...

a bit of .gitignore can prevent future accidents

— Reply to this email directly, view it on GitHub https://github.com/PowerDNS/weakforced/pull/425#issuecomment-2154590873, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADS27WB7FUPXV2WI7YBNM2LZGGGI5AVCNFSM6AAAAABIYTBB22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUGU4TAOBXGM. You are receiving this because you authored the thread.