PowerGridModel / power-grid-model-io

Conversion tool for various grid data formats to power-grid-model
Mozilla Public License 2.0
12 stars 8 forks source link

[feature] DGC 2080 Pandapower different datatype handling #217

Closed Jerry-Jinfeng-Guo closed 7 months ago

Jerry-Jinfeng-Guo commented 7 months ago

This is an updated PR from #213 (w/ proper title)

mgovers commented 7 months ago

@Jerry-Jinfeng-Guo is this something we should merge today? If so, i can review and approve

Jerry-Jinfeng-Guo commented 7 months ago

@Jerry-Jinfeng-Guo is this something we should merge today? If so, i can review and approve

Github checks are somehow behind schedule. If you have time for it, yes please? @mgovers

mgovers commented 7 months ago

@Jerry-Jinfeng-Guo is this something we should merge today? If so, i can review and approve

Github checks are somehow behind schedule. If you have time for it, yes please? @mgovers

probably related to the fact that the commits are already present on main, which is why CI is not triggered again. As a result, there aren't any jobs that will report to this PR. merging with main and ensuring that all the files are correctly present in the new PR should do the trick.

Beware: merging with main may remove the changes due to the reverting of changes in this PR.

Jerry-Jinfeng-Guo commented 7 months ago

Please note that the code currently fails 3 tests: one is not converter related, while other two are expected to be removed entirely

Jerry-Jinfeng-Guo commented 7 months ago

Remaining TODO's in the validation test: Two to-be-removed tests in tests/validation/converters/test_pandapower_converter_output.py

@nitbharambe could you confirm this?

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Jerry-Jinfeng-Guo commented 7 months ago

PR merged.