search

PowerGridModel / power-grid-model-io

Conversion tool for various grid data formats to power-grid-model
Mozilla Public License 2.0
12 stars 8 forks source link

DGC-2079 Logging level to base converter #219

Closed Jerry-Jinfeng-Guo closed 7 months ago

Jerry-Jinfeng-Guo commented 7 months ago

Initial implementation following @JeanDosSantos's input on Teams. Added log level, defaulted to ERROR but configurable. A small unit test is also included.

Jerry-Jinfeng-Guo commented 7 months ago

At the moment some of the tests are failing. They don't appear as directly related to the code added. In particular: test_serialize_data and others. Since pgm-io is still impossible for me to debug, could anyone take a look at the branch? Thanks!

mgovers commented 7 months ago

At the moment some of the tests are failing. They don't appear as directly related to the code added. In particular: test_serialize_data and others. Since pgm-io is still impossible for me to debug, could anyone take a look at the branch? Thanks!

I did some quick digging and it seems to have to do with the fact that the structlog configure is global

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud