Closed Jerry-Jinfeng-Guo closed 6 months ago
Regardless of the path going forward, exposing the *.yaml
configuration file is a good idea. Hasn't this been done already?
Nope, not yet. Hence that will be the first PR in this issue.
Nope, not yet. Hence that will be the first PR in this issue.
can you do that when you have time? i think this is important and small enough to "just do it"
Step 1: https://github.com/PowerGridModel/power-grid-model-io/pull/226 @mgovers If you could give a review
@Jerry-Jinfeng-Guo , #232 is merged. This issue can be closed, right?
@Jerry-Jinfeng-Guo , #232 is merged. This issue can be closed, right?
Yes.
Vision 9.7 has introduced many changes to the exported excel sheet, which brings challenge to the existing
VisionExcelConverter
. Most significantly, UUID was introduced as the new id scheme. However, older versions like <9.6 are still extensively used by users who wish to take advantage of PGM as their compute core. To address this, we need to update our code base to accomdate the changes.Here is the proposed temporary work-around:
In the case that
VisionExcelConverter
is to be continued, here are the proposed solutions:*.yaml
configuration files as parameters to the converter. Currently one file is provided and users need to modify that versioned file or they need to go deep to the converter definition code to load any other configuration file. By making this a parameter, we could explicitly offload the whole*.yaml
configuration task to users.Number
/Node.Number
the same asGUID
/Node.GUID
and convert them all to strings in python. They are then collected to a map where each string key maps to an integer. This way, we combines the existing id scheme well with both Vision 9.7 UUID based scheme and Vision sub 9.6 number based scheme.N1
now asGrounding1
. Many other such changes need to be mapped out accurately.