PowerGridModel / power-grid-model-io

Conversion tool for various grid data formats to power-grid-model
Mozilla Public License 2.0
12 stars 8 forks source link

[FEATURE] Support for multiple Vision Excel versions #225

Closed Jerry-Jinfeng-Guo closed 6 months ago

Jerry-Jinfeng-Guo commented 6 months ago

Vision 9.7 has introduced many changes to the exported excel sheet, which brings challenge to the existing VisionExcelConverter. Most significantly, UUID was introduced as the new id scheme. However, older versions like <9.6 are still extensively used by users who wish to take advantage of PGM as their compute core. To address this, we need to update our code base to accomdate the changes.

Here is the proposed temporary work-around:

In the case that VisionExcelConverter is to be continued, here are the proposed solutions:

mgovers commented 6 months ago

Regardless of the path going forward, exposing the *.yaml configuration file is a good idea. Hasn't this been done already?

Jerry-Jinfeng-Guo commented 6 months ago

Nope, not yet. Hence that will be the first PR in this issue.

mgovers commented 6 months ago

Nope, not yet. Hence that will be the first PR in this issue.

can you do that when you have time? i think this is important and small enough to "just do it"

Jerry-Jinfeng-Guo commented 6 months ago

Step 1: https://github.com/PowerGridModel/power-grid-model-io/pull/226 @mgovers If you could give a review

Jerry-Jinfeng-Guo commented 6 months ago

Step 0: https://github.com/PowerGridModel/power-grid-model-io/pull/227

Jerry-Jinfeng-Guo commented 6 months ago

Step 1-3: https://github.com/PowerGridModel/power-grid-model-io/pull/232

mgovers commented 6 months ago

@Jerry-Jinfeng-Guo , #232 is merged. This issue can be closed, right?

Jerry-Jinfeng-Guo commented 6 months ago

@Jerry-Jinfeng-Guo , #232 is merged. This issue can be closed, right?

Yes.