search

PowerGridModel / power-grid-model-io

Conversion tool for various grid data formats to power-grid-model
Mozilla Public License 2.0
12 stars 8 forks source link

Feature/support UUID vision input #232

Closed Jerry-Jinfeng-Guo closed 6 months ago

Jerry-Jinfeng-Guo commented 6 months ago

Native support for UUID based id excel sheet from Vision >9.7

Relates to #225

Jerry-Jinfeng-Guo commented 6 months ago

Interesting. The last commit didn't trigger CI

mgovers commented 6 months ago

Interesting. The last commit didn't trigger CI

Yes i had that as well this morning. Appears to be a bug where github hooks are not triggered (including the repo backend itself)

Jerry-Jinfeng-Guo commented 6 months ago

One last consideration: should we maybe use an enum for the language? My guess is no but just calling it out so that we at least don't shoot ourselves in the foot later on

I don't think so either, strings are somewhat backward compatible and more intuitive. IMO enums are nicer when there are multiple items but do not have a common way to group them. Language on the other hand... (https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes#Table)

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud