PowerNukkit / Java2Nukkit-World-Converter

Converts worlds from Minecraft 1.15.2+ Java Edition to the newest Nukkit MCA file format
MIT License
23 stars 6 forks source link

minecraft:banner_pattern items aren't migrated #8

Closed joserobjr closed 5 years ago

joserobjr commented 5 years ago

The item id is currently unknown.

joserobjr commented 5 years ago

Using a "hacked" PocketMine-MP server I managed to get how the banner pattern is save in a chest, and apparently the new save format does not includes numeric ids but this information might be useful.

pocketmine\nbt\tag\CompoundTag Object
(
    [value:pocketmine\nbt\tag\CompoundTag:private] => Array
        (
            [Findable] => pocketmine\nbt\tag\ByteTag Object
                (
                    [value:pocketmine\nbt\tag\ByteTag:private] => 0
                    [__name:protected] => Findable
                    [cloning:protected] =>
                )

            [Items] => pocketmine\nbt\tag\ListTag Object
                (
                    [tagType:pocketmine\nbt\tag\ListTag:private] => 10
                    [value:pocketmine\nbt\tag\ListTag:private] => SplDoublyLinkedList Object
                        (
                            [flags:SplDoublyLinkedList:private] => 0
                            [dllist:SplDoublyLinkedList:private] => Array
                                (
                                    [0] => pocketmine\nbt\tag\CompoundTag Object
                                        (
                                            [value:pocketmine\nbt\tag\CompoundTag:private] => Array
                                                (
                                                    [Count] => pocketmine\nbt\tag\ByteTag Object
                                                        (
                                                            [value:pocketmine\nbt\tag\ByteTag:private] => 1
                                                            [__name:protected] => Count
                                                            [cloning:protected] =>
                                                        )

                                                    [Damage] => pocketmine\nbt\tag\ShortTag Object
                                                        (
                                                            [value:pocketmine\nbt\tag\ShortTag:private] => 2
                                                            [__name:protected] => Damage
                                                            [cloning:protected] =>
                                                        )

                                                    [Name] => pocketmine\nbt\tag\StringTag Object
                                                        (
                                                            [value:pocketmine\nbt\tag\StringTag:private] => minecraft:banner_pattern
                                                            [__name:protected] => Name
                                                            [cloning:protected] =>
                                                        )

                                                    [Slot] => pocketmine\nbt\tag\ByteTag Object
                                                        (
                                                            [value:pocketmine\nbt\tag\ByteTag:private] => 0
                                                            [__name:protected] => Slot
                                                            [cloning:protected] =>
                                                        )

                                                )

                                            [__name:protected] =>
                                            [cloning:protected] =>
                                        )

                                )

                        )

                    [__name:protected] => Items
                    [cloning:protected] =>
                )

            [id] => pocketmine\nbt\tag\StringTag Object
                (
                    [value:pocketmine\nbt\tag\StringTag:private] => Chest
                    [__name:protected] => id
                    [cloning:protected] =>
                )

            [isMovable] => pocketmine\nbt\tag\ByteTag Object
                (
                    [value:pocketmine\nbt\tag\ByteTag:private] => 1
                    [__name:protected] => isMovable
                    [cloning:protected] =>
                )

            [x] => pocketmine\nbt\tag\IntTag Object
                (
                    [value:pocketmine\nbt\tag\IntTag:private] => 0
                    [__name:protected] => x
                    [cloning:protected] =>
                )

            [y] => pocketmine\nbt\tag\IntTag Object
                (
                    [value:pocketmine\nbt\tag\IntTag:private] => 1
                    [__name:protected] => y
                    [cloning:protected] =>
                )

            [z] => pocketmine\nbt\tag\IntTag Object
                (
                    [value:pocketmine\nbt\tag\IntTag:private] => 0
                    [__name:protected] => z
                    [cloning:protected] =>
                )

        )

    [__name:protected] =>
    [cloning:protected] =>
)
joserobjr commented 5 years ago

Based on this commit from RoseFast, the banner_pattern id is 434 https://github.com/rosedust/RoseFast/commit/2e5ef4ba0335527c86a940e377a358a061c3f204#diff-13151842f02a3fd66fd6a0a962412ea0R551

Also available in PocketMine's latest commit: https://github.com/pmmp/PocketMine-MP/blob/76e5ea385b0b39670017a26347d190968a5adf1d/src/pocketmine/item/ItemIds.php#L207