PowerShell / AIShell

An interactive shell to work with AI-powered assistance providers
MIT License
68 stars 19 forks source link

Fix how we retrieve the installation id form AzCLI and AzPSH profile #260

Closed NoriZC closed 2 weeks ago

NoriZC commented 2 weeks ago

PR Summary

PR Context

daxian-dbw commented 2 weeks ago

@NoriZC Please revert the changes in AzureAgent.cs. We will put off telemetry code changes until the metrics for each telemetry are well defined.

NoriZC commented 2 weeks ago

@NoriZC Please revert the changes in AzureAgent.cs. We will put off telemetry code changes until the metrics for each telemetry are well defined.

OK, I will seperate this PR soon

daxian-dbw commented 2 weeks ago

OK, I will seperate this PR soon

Do not work on the new changes yet. We need the metrics to be well defined before start coding work. We don't want to make changes again and again.

daxian-dbw commented 2 weeks ago

@NoriZC You can continue with fixing installation id in this PR, but please revert the unrelated changes.