Closed calvinhzy closed 1 day ago
I’ve made some changes to the script, and will push to the PR later tonight, please hold off any changes before that.
From: Steven Bucher @.> Sent: Friday, November 15, 2024 3:34:34 PM To: PowerShell/ProjectMercury @.> Cc: Dongbo Wang @.>; Mention @.> Subject: Re: [PowerShell/ProjectMercury] Install/uninstall script (PR #285)
@StevenBucher98 commented on this pull request.
In tools/scripts/script.ps1https://github.com/PowerShell/ProjectMercury/pull/285#discussion_r1844663206:
+# ---------------------------------------------------------------------------------- + +param(
- [Parameter(HelpMessage = "Specify this parameter to uninstall AIShell")]
- [switch] $Uninstall +)
+<################################################# +# +# Helper functions +# +#################################################>
+function Get-PowerShellVersion {
- if ([version]$PSVersionTable.PSVersion -lt [version]"7.4.6") {
- Write-Warning "[PowerShell version 7.4.6 is the minimum requirement for AIShell module, exiting...]"
Agreed we should add where they can install PS 7.4.6
— Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/ProjectMercury/pull/285#discussion_r1844663206, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAA7DWVTJEIUUYIRYVAVFOD2A2AIVAVCNFSM6AAAAABRSBHSL2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZZHEZDQMBVGI. You are receiving this because you were mentioned.Message ID: @.***>
@calvinhzy @StevenBucher98 Given the issues with the script and the tight timeline, I rewrote some of the install script to get it ready for try-out and iterative updates. Make sure you sync this branch if you are making code updates. @calvinhzy Note that I haven't get a chance to test the new implementation yet, so please go-ahead testing and fixing issues that you might find.
PR Summary
Add the installation script to facilitate the AIShell installation and uninstallation.