PowerShell / ConsoleGuiTools

Modules that mix PowerShell and GUIs/CUIs!
https://www.powershellgallery.com/packages/Microsoft.PowerShell.ConsoleGuiTools
MIT License
794 stars 60 forks source link

OCGV: Configurable background color for Out-ConsoleGridView #129

Open r-darwish opened 3 years ago

r-darwish commented 3 years ago

The default colors don't look well on every theme. It would be nice if we could configure them.

tig commented 3 years ago

Can you share more details of what looks good and doesn't on your system?

Terminal.Gui, on which ocgv is based supports multiple color themes. One solution would be to add a switch to ocgv that lets the user choose these:

Base: image

TopLevel: image

Dialog: image

Error: image

Finding color schemes that work well cross-platform is a real challenge. We do have the ability to tweak the defaults across some platforms so if there's something in one of the defaults that looks awful on, say Linux, we have some control.

Fred-Vatin commented 3 years ago

Yes maybe a general theme setting for all terminal.gui applications or/and a specific command to set ocgv theme like set-ocgvColors and passing a hash table with colors like we do with Set-PSReadLineOption -Colors $myTheme.

I reckon some colors of ocgv don’t match. ocgv use darkcyan for title and the last focus line on blue bg. What a weird choice. Here it is with the built-in campbell theme for wt. image

Here was my personal theme for wt. image image

Adjusting my theme, I can get a better contrast. image

However we definitely need a way to custom ocgv colors.

jdhitsolutions commented 2 years ago

I'll add my vote on this. In Windows Terminal, the only way you can adjust the display is to modify the color scheme definition for values like Blue and Cyan.

tig commented 2 years ago

Question for @r-darwish, @jdhitsolutions, and @freMea:

I think there are two issues here:

1) The use of "blue on blue" for the list highlight is hard to see/has poor contrast. 2) It would be nice to have the color scheme be user-configurable

Does this accurately reflect your take?

Fred-Vatin commented 2 years ago

Yes

tig commented 2 years ago

Ok. Thank you for the feedback!

For 1. see https://github.com/migueldeicaza/gui.cs/issues/1773

For 2. see https://github.com/migueldeicaza/gui.cs/issues/29

tig commented 2 years ago

https://github.com/gui-cs/Terminal.Gui/issues/1773 has been fixed and will be in Terminal.Gui v1.7.2 which I plan on launching in the next day. It will be incorporated into the next GraphicalTools release.

image

It's not a dramatic change, but does make the not-focused but selected listview item easier to read.

Providing customizable colors is a future item...

tig commented 2 years ago

@andschwa please prefix title with "OCGV: ".

tig commented 1 year ago

Terminal.Gui v2.x will fix this.

See https://github.com/gui-cs/Terminal.Gui/issues/2181

I plan on a re-write of OCGV using Terminal.Gui v2 in the next few months.

HotCakeX commented 8 months ago

Really need a way to customize background color...