Open r-darwish opened 3 years ago
Can you share more details of what looks good and doesn't on your system?
Terminal.Gui
, on which ocgv
is based supports multiple color themes. One solution would be to add a switch to ocgv
that lets the user choose these:
Base:
TopLevel:
Dialog:
Error:
Finding color schemes that work well cross-platform is a real challenge. We do have the ability to tweak the defaults across some platforms so if there's something in one of the defaults that looks awful on, say Linux, we have some control.
Yes maybe a general theme setting for all terminal.gui applications or/and a specific command to set ocgv theme like set-ocgvColors
and passing a hash table with colors like we do with Set-PSReadLineOption -Colors $myTheme
.
I reckon some colors of ocgv don’t match. ocgv use darkcyan for title and the last focus line on blue bg. What a weird choice. Here it is with the built-in campbell theme for wt.
Here was my personal theme for wt.
Adjusting my theme, I can get a better contrast.
However we definitely need a way to custom ocgv colors.
I'll add my vote on this. In Windows Terminal, the only way you can adjust the display is to modify the color scheme definition for values like Blue and Cyan.
Question for @r-darwish, @jdhitsolutions, and @freMea:
I think there are two issues here:
1) The use of "blue on blue" for the list highlight is hard to see/has poor contrast. 2) It would be nice to have the color scheme be user-configurable
Does this accurately reflect your take?
Yes
Ok. Thank you for the feedback!
For 1. see https://github.com/migueldeicaza/gui.cs/issues/1773
For 2. see https://github.com/migueldeicaza/gui.cs/issues/29
https://github.com/gui-cs/Terminal.Gui/issues/1773 has been fixed and will be in Terminal.Gui v1.7.2 which I plan on launching in the next day. It will be incorporated into the next GraphicalTools
release.
It's not a dramatic change, but does make the not-focused but selected listview item easier to read.
Providing customizable colors is a future item...
@andschwa please prefix title with "OCGV: ".
Terminal.Gui v2.x will fix this.
See https://github.com/gui-cs/Terminal.Gui/issues/2181
I plan on a re-write of OCGV using Terminal.Gui v2 in the next few months.
Really need a way to customize background color...
The default colors don't look well on every theme. It would be nice if we could configure them.