PowerShell / ConsoleGuiTools

Modules that mix PowerShell and GUIs/CUIs!
https://www.powershellgallery.com/packages/Microsoft.PowerShell.ConsoleGuiTools
MIT License
759 stars 52 forks source link

Fix clear last line on Windows Terminal Issue again (#203). #207

Closed tig closed 9 months ago

tig commented 11 months ago

PR Summary

There are cases where the previous fix to #203 (#205) didn't work.

There are a lot of interactions between the platform (Windows v. Linux), terminal (e.g. Windows Terminal vs. VS Code's terminal), and Terminal.Gui's various drivers that conflict and are confusing. In addition, it's challenging to understand what code is actaully loaded when running a CmdLet. Hence the new diagnostics and ability to force NetDriver.

Note, with Terminal.Gui v2, the need for -UseNetDriver goes away because the new ConfigurationManager lets users set options like that globally, per-user, or on an app-by-app basis.

tig commented 11 months ago

Marked as draft until Terminal.Gui v1.14.x gets released.

tig commented 9 months ago

@andyleejordan I think this is ready now.

andyleejordan commented 9 months ago

@tig reviewing now! Sorry, I was out sick for a while which pushed everything back on my schedule.

andyleejordan commented 9 months ago

Ok awesome, I built and tested locally and can't repro #203 with this, yay! However, when I tested with -UseNetDriver I ended up with a blank line that wouldn't go away:

image

Is that a known issue with the .NET driver? I don't think I'm going to consider it a blocker since the default (with the Windows driver) worked fine.