Closed PlagueHO closed 7 years ago
@PlagueHO, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request. Thanks, Microsoft Pull Request Bot
Tagging @zjalexander and @mgreenegit as per DSC community call instruction.
I have made a bunch of fixes that I can send in, but I need this one to merge first, because I'm dependent on this one. Commits that are pending to be sent in; https://github.com/johlju/DscConfiguration.Tests/commits/fixes-issues
This PR is pointing to merged into master, shouldn't it be merged into dev first? See issue #30.
Looks good. Thank you!
This PR addresses:
The main issue I ran into when creating a config using this pattern was that my Azure subscription for some reason didn't allow me to create the VMs required to execute the automated tests in the default EastUS2 data center. So I needed a way to override the location.
I also find it useful to upload the Pester test results into AppVeyor as files I can download and distribute (as we do with DSC Resource Kit).
As I was also making changes to this, I thought a Changelog should also be included in the README.MD so I added one.
This PR changes:
$ENV:Location
environment variable. Will default to 'EastUS2' if not specified.This change is